@deads2k @dcbw PTAL

lgetm

too much work to rewire the underlying controller to be more "normal"?

needs picking back to 3.6 (exists there too), so keeping it minimal for the moment

needs picking back to 3.6 (exists there too), so keeping it minimal for the moment

ok

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 16

Evaluated for origin merge up to 254aa79

[Test]ing while waiting on the merge queue

@liggitt it's not immediately clear to me why the fix in ee76e3e is no longer valid? #14633 moved to the goroutine, now this reverts that. Is that OK?

Ah, nevermind, looks like #14633 moved from not-goroutine to a goroutine for all the controllers it touched, but now that's no longer necessary?

[test]

#14633 puts all controller initialization in a goroutine isolated from the api startup. it expects each controller's init function to register shared informer event handlers synchronously, spawn workers in goroutines, then return. once all init functions return, the controller code starts the shared informers.

removed merge tag, updated with potential fix restoring controller role reconciliation at startup. PTAL

[test][merge]

Evaluated for origin test up to d6c198a

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3348/) (Base Commit: 7a48deb) (PR Branch Commit: d6c198a)

green tests on latest master. merging to unblock the queue.